Support nested Parameters. #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support nested Parameters by adding a type assertion to the query loop in evaluationStage.go. Remove the check for unexported accessors in the parser, and replace with a check for unexported field access in evaluationStage. This allows nesting maps in an arbitrary fashion with the MapParameters type, as shown by the unit test. Fixes Knetic#70
This was referenced Nov 22, 2017
|
Any chance of getting this merged in? We're maintaining a fork currently. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support nested Parameters by adding a type assertion to the query
loop in evaluationStage.go. Remove the check for unexported
accessors in the parser, and replace with a check for unexported
field access in evaluationStage.
This allows nesting maps in an arbitrary fashion with the
MapParameters type, as shown by the unit test.
Fixes #70